Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaCrosse View new endpoint #137284

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

IceBotYT
Copy link
Contributor

@IceBotYT IceBotYT commented Feb 4, 2025

Proposed change

Implements new endpoint to LaCrosse View that should use less HTTP traffic and be subject to less rate limiting.
Depends on #137282

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@IceBotYT
Copy link
Contributor Author

IceBotYT commented Feb 4, 2025

Forgot to tick the bugfix box.. whoops

@IceBotYT IceBotYT force-pushed the lacrosse-view-new-endpoint branch from 0a0c7bb to 031cfd6 Compare February 5, 2025 01:08
@IceBotYT IceBotYT marked this pull request as ready for review February 5, 2025 12:24
@IceBotYT IceBotYT marked this pull request as draft February 5, 2025 12:27
@IceBotYT IceBotYT force-pushed the lacrosse-view-new-endpoint branch from 031cfd6 to 1fc8a4b Compare February 5, 2025 20:44
@IceBotYT IceBotYT marked this pull request as ready for review February 5, 2025 20:44
@home-assistant
Copy link

home-assistant bot commented Feb 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 7, 2025 08:51
@IceBotYT IceBotYT force-pushed the lacrosse-view-new-endpoint branch from 1fc8a4b to edd4580 Compare February 8, 2025 01:36
@IceBotYT IceBotYT marked this pull request as ready for review February 8, 2025 01:36
@home-assistant home-assistant bot requested a review from zweckj February 8, 2025 01:36
@zweckj zweckj added the bugfix label Feb 8, 2025
@zweckj zweckj added this to the 2025.2.2 milestone Feb 8, 2025
@zweckj zweckj merged commit 332a0c5 into home-assistant:dev Feb 8, 2025
32 checks passed
@IceBotYT IceBotYT deleted the lacrosse-view-new-endpoint branch February 8, 2025 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants